Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm generation checker pipeline #1209

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix: helm generation checker pipeline #1209

merged 3 commits into from
Apr 12, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Apr 11, 2023 •
edited
Loading

This PR

  • fixed helm generation checker pipeline
  • executed make manifests && make generate on each operator
  • executed make helm-package
  • add ignore to yamllint check for generated files (they have different indentation)

@netlify
Copy link

netlify bot commented Apr 11, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c587bfe
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/643558280f63110008343e6e
😎 Deploy Preview https://deploy-preview-1209--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #1209 (3ee2dbe) into main (b261172) will increase coverage by 0.33%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
+ Coverage   58.63%   58.96%   +0.33%     
==========================================
  Files         114      128      +14     
  Lines        9493    10040     +547     
==========================================
+ Hits         5566     5920     +354     
- Misses       3753     3901     +148     
- Partials      174      219      +45

see 26 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
lifecycle-operator 78.24% <ø> (?)
metrics-operator 77.57% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added ops helm and removed helm labels Apr 11, 2023
@odubajDT odubajDT marked this pull request as ready for review April 12, 2023 08:27
aepfli
aepfli previously approved these changes Apr 12, 2023
View reviewed changes
RealAnna
RealAnna reviewed Apr 12, 2023
View reviewed changes
helm/chart/values.yaml Outdated Show resolved Hide resolved
@odubajDT
pr review
3ee2dbe 
Signed-off-by: odubajDT <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT merged commit 72396cd into keptn:main Apr 12, 2023
@keptn-bot keptn-bot mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

@aepfli aepfli aepfli left review comments

@thisthat thisthat Awaiting requested review from thisthat

@thschue thschue Awaiting requested review from thschue

@mowies mowies Awaiting requested review from mowies

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees
No one assigned
Labels
cert-manager helm metrics-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odubajDT @bacherfl @aepfli @RealAnna